Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos ignore file #185

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Add typos ignore file #185

merged 9 commits into from
Apr 15, 2024

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Apr 15, 2024

@sloede
Copy link
Member

sloede commented Apr 15, 2024

Fixes #182

Unfortunately not 😓

@benegee benegee requested a review from sloede April 15, 2024 06:39
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (ddd5dd8) to head (24bc27b).
Report is 2 commits behind head on main.

❗ Current head 24bc27b differs from pull request most recent head 27cd08f. Consider uploading reports for the commit 27cd08f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          19       19           
  Lines         715      715           
  Branches       50       50           
=======================================
  Hits          574      574           
  Misses        137      137           
  Partials        4        4           
Flag Coverage Δ
unittests 80.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member

sloede commented Apr 15, 2024

Why not just add a .typos.yml file to the main directory, to be consistent with Trixi.jl et al.?

@benegee
Copy link
Collaborator Author

benegee commented Apr 15, 2024

I had not realized Trixi.jl was using it.

@sloede sloede merged commit bfef721 into main Apr 15, 2024
8 checks passed
@sloede sloede deleted the bg/add-typos-ignore-file branch April 15, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in typos
2 participants